Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently retry Fronius inverter endpoint 2 times #61826

Merged
merged 2 commits into from Dec 19, 2021

Conversation

farmio
Copy link
Contributor

@farmio farmio commented Dec 14, 2021

Proposed change

Almost 1% of current_inverter_data() (GetInverterRealtimeData.cgi with device scope) requests on Symo devices result in BadStatusError Code: 8 - LNRequestTimeout due to flaky internal communication between Datalogger (our bridge device) and inverter.
Subsequent calls always succeeded in my ~5000 tests - so we retry 2 times silently before raising an error (and writing to the log).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @nielstron, mind taking a look at this pull request as it has been labeled with an integration (fronius) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Member

Tag for a patch release?

@farmio farmio added this to the 2021.12.4 milestone Dec 19, 2021
@farmio farmio merged commit 37bed64 into home-assistant:dev Dec 19, 2021
@farmio farmio deleted the fronius-flaky-inverter branch December 19, 2021 10:39
@farmio
Copy link
Contributor Author

farmio commented Dec 19, 2021

Thanks for your review!

@balloob balloob mentioned this pull request Dec 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fronius integration timeouts with inverter
4 participants