Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deconz light service parameter handling #62128

Merged

Conversation

schmyd
Copy link
Contributor

@schmyd schmyd commented Dec 16, 2021

Breaking change

Proposed change

Revert most of the dictionary creation method to not interpret the values of the incoming dictionary itself, but only their presence.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@schmyd schmyd requested a review from Kane610 as a code owner December 16, 2021 22:40
@homeassistant
Copy link
Contributor

Hi @schmyd,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (deconz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't revert back, guard against None instead.

homeassistant/components/deconz/light.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Dec 17, 2021
@schmyd
Copy link
Contributor Author

schmyd commented Dec 19, 2021

removed reverting of the previous change, guarded against None now. Adapted handling of ATTR_EFFECT and ATTR_FLASH. Let me know if you expect more tests here

@schmyd schmyd requested a review from Kane610 December 20, 2021 20:25
Dev automation moved this from Review in progress to Reviewer approved Dec 20, 2021
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Test coverage is kept at 100% right?

@schmyd
Copy link
Contributor Author

schmyd commented Dec 20, 2021

yes, still at 100%

@MartinHjelmare MartinHjelmare changed the title Only check presence of values, not their content Fix deconz light service parameter handling Dec 20, 2021
Copy link

@alexanderlindstrom alexanderlindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find no issues with this code. Good job.
Though not part of your changes, the test file could use some lint checks to make it more uniform.

@Kane610 Kane610 added this to the 2021.12.5 milestone Dec 22, 2021
@Kane610 Kane610 merged commit f135d77 into home-assistant:dev Dec 22, 2021
Dev automation moved this from Reviewer approved to Done Dec 22, 2021
@Kane610
Copy link
Member

Kane610 commented Dec 22, 2021

Thanks for contributing!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2021
@schmyd schmyd deleted the deconz-handle-bool-false-values-correctly branch January 12, 2024 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Transitiontime ignored when zero for deconz lights
5 participants