-
-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align zeroconf matching with ZeroconfServiceInfo #62133
Conversation
Currently zeroconf matching only allows matching the macaddress model and manufacturer properties along with the name from the ZeroconfServiceInfo. Since properties are arbitrarily defined by the zeroconf service, the list of named properties has grown over time. Matching now allows for any arbitrarily defined property All property matches must be lowercase, wildcards are supported
Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @oblogic7, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @escoand, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for Axis integration
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Thanks. This unblocks the HomePod support for apple_tv |
Breaking change
Currently zeroconf matching only allows matching the
macaddress
model
, andmanufacturer
properties along with thename
fromthe ZeroconfServiceInfo. Since properties are arbitrarily
defined by the zeroconf service, the list of named properties
has grown over time.
Matching now allows for any arbitrarily defined property
All property matches must be lowercase, wildcards are supported
Replaces #62001
The top level keys
model
,manufacturer
, andmacaddress
are now deprecated from the
manifest.json
file and shouldbe moved into a
properties
dict.Example:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: