Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EntityCategory enum for MusicCast entity types #62303

Merged
merged 2 commits into from Dec 21, 2021
Merged

Use EntityCategory enum for MusicCast entity types #62303

merged 2 commits into from Dec 21, 2021

Conversation

micha91
Copy link
Contributor

@micha91 micha91 commented Dec 19, 2021

Proposed change

For cleaner code we use the EntityCategory enum instead of the constants. In addition we removed the EntityType.System in aiomusiccast (release notes) and its mapping in Home Assistant, as it is not used anywhere and should not be used in aiomusiccast anyway. This is a follow up of #61218.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @vigonotion, mind taking a look at this pull request as it has been labeled with an integration (yamaha_musiccast) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 19, 2021
Dev automation moved this from By Code Owner to Review in progress Dec 19, 2021
@frenck
Copy link
Member

frenck commented Dec 20, 2021

@micha91 Please git rebase this PR onto the latest dev to resolve the CI issue.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @micha91 👍

Dev automation moved this from Review in progress to Reviewer approved Dec 21, 2021
@frenck frenck merged commit 0540c94 into home-assistant:dev Dec 21, 2021
Dev automation moved this from Reviewer approved to Done Dec 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants