Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nissan leaf climate control (icon + fire & forget) #62855

Closed
wants to merge 2 commits into from

Conversation

filcole
Copy link
Contributor

@filcole filcole commented Dec 27, 2021

Proposed change

Add a fan icon to the climate control switch in same style as Renault integration.
Nissan servers do not send a usable climate control on/off response, so fire and forget on/off request instead.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Don't error on climate control on/off switch change. Add better icon.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Dec 27, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 27, 2021
@davet2001
Copy link
Contributor

For fire and forget, do you also need to change the assumed state attribute?

https://www.home-assistant.io/docs/configuration/state_object/

@filcole
Copy link
Contributor Author

filcole commented Dec 29, 2021

Hi @davet2001, I tried setting assumed_state temporarily and then immediately requesting fresh state from the Nissan servers (takes about 1 minute). During that time the control changes from a switch to two lightning bolts, which I don't think is what we want. Thanks for suggestion - because I will update it to now request and update within the minimum update period (2 mins) after climate change state change.

@filcole
Copy link
Contributor Author

filcole commented Dec 29, 2021

Replaced by #63029

@filcole filcole closed this Dec 29, 2021
Dev automation moved this from By Code Owner to Cancelled Dec 29, 2021
@filcole filcole deleted the nissanleaf_climatecontrol branch December 29, 2021 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

3 participants