New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KNX Expose for strings longer than 14 bytes #63026
Conversation
Hey there @Julius2342, @farmio, mind taking a look at this pull request as it has been labeled with an integration ( |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
2a17f3c
to
eb5223b
Compare
eb5223b
to
f749611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤
Proposed change
KNX Expose should not try to send too long strings. The underlying data type allows a maximum of 14 bytes which for ASCII, is 14 characters.
This PR cuts the remaining characters if the string is too long and avoids an exception in the library. Users shouldn't have to deal with this error.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: