Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MQTT cover not using tilt_command_template #63080

Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Dec 30, 2021

Proposed change

The tilt_command_template of the cover platform only apples tilt_command_template when setting the tilt position when SERVICE_SET_COVER_TILT_POSITION is called.
It is needed the tilt_command_template is also applied when when SERVICE_OPEN_COVER_TILT and SERVICE_CLOSE_COVER_TILT is called. This PR fixes that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Dec 30, 2021
Dev automation moved this from Needs review to Reviewer approved Jan 3, 2022
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh 馃憤

@emontnemery emontnemery merged commit 0dab5e6 into home-assistant:dev Jan 3, 2022
Dev automation moved this from Reviewer approved to Done Jan 3, 2022
@jbouwh jbouwh deleted the fix-mqtt-cover-tilt-template branch January 3, 2022 19:20
jeeftor pushed a commit to jeeftor/core that referenced this pull request Jan 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

MQTT Cover - Tilt command template is ignored
3 participants