Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfixes for UniFi Protect #63475

Merged
merged 4 commits into from Jan 8, 2022
Merged

Conversation

AngellusMortis
Copy link
Contributor

@AngellusMortis AngellusMortis commented Jan 5, 2022

Proposed change

A backport of some bugfixes from HACS integration:

  • Upgrade pyunifiprotect to 1.5.3. Changelog: AngellusMortis/pyunifiprotect@v1.4.8...v1.5.3
    • Most notable is better UP Sense support, so no errors are thrown about the new events and some bugfixes
  • Fixes NVR memory sensor if no data was reported
  • Fixes "is connected" check for camera entities
  • Removes custom device class for Doorbell Ring sensor since downstream things (i.e. HomeKit) expect a doorbell ring to be an occupancy
  • Reworks Doorbell Ring sensor to make it significantly more reliable and work like other binary sensors

TODO for the rest of the UniFi Protect HACS migration after this PR:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 5, 2022
@AngellusMortis
Copy link
Contributor Author

This PR may need to be blocked until 3.8 is actually dropped from core. @frenck said it was going to happen in right before the beta cut.

@frenck frenck marked this pull request as draft January 5, 2022 15:16
@frenck
Copy link
Member

frenck commented Jan 5, 2022

Converted PR to draft, since Python 3.8 isn't dropped yet

@AngellusMortis AngellusMortis changed the title Bumps pyunifiprotect to 2.0.0 Bumps pyunifiprotect to 1.5.0 Jan 6, 2022
@AngellusMortis AngellusMortis marked this pull request as ready for review January 6, 2022 22:02
@AngellusMortis
Copy link
Contributor Author

Switched from 2.0.0 to 1.5.0 (with the features I needed backported, but keeping 3.8 support).

@bdraco
Copy link
Member

bdraco commented Jan 6, 2022

Looks like it was too quick. I'll restart the CI

@bdraco bdraco marked this pull request as draft January 6, 2022 22:20
@AngellusMortis AngellusMortis marked this pull request as ready for review January 6, 2022 22:45
@AngellusMortis AngellusMortis changed the title Bumps pyunifiprotect to 1.5.0 Bumps pyunifiprotect to 1.5.1 Jan 6, 2022
@AngellusMortis AngellusMortis marked this pull request as draft January 6, 2022 22:52
@AngellusMortis AngellusMortis changed the title Bumps pyunifiprotect to 1.5.1 Bumps pyunifiprotect to 1.5.3 Jan 8, 2022
@AngellusMortis AngellusMortis marked this pull request as ready for review January 8, 2022 13:59
@AngellusMortis AngellusMortis changed the title Bumps pyunifiprotect to 1.5.3 Minor bugfixes for UniFi Protect Jan 8, 2022
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Jan 8, 2022
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco bdraco merged commit 8860549 into home-assistant:dev Jan 8, 2022
Dev automation moved this from Reviewer approved to Done Jan 8, 2022
@AngellusMortis AngellusMortis deleted the ufp-bump branch January 8, 2022 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants