New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bugfixes for UniFi Protect #63475
Conversation
Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
This PR may need to be blocked until 3.8 is actually dropped from core. @frenck said it was going to happen in right before the beta cut. |
Converted PR to draft, since Python 3.8 isn't dropped yet |
e1f22a5
to
062b756
Compare
Switched from 2.0.0 to 1.5.0 (with the features I needed backported, but keeping 3.8 support). |
Looks like it was too quick. I'll restart the CI |
062b756
to
9144dd2
Compare
9144dd2
to
0a690a6
Compare
0a690a6
to
e0e69ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AngellusMortis
Thanks @MartinHjelmare
Proposed change
A backport of some bugfixes from HACS integration:
pyunifiprotect
to 1.5.3. Changelog: AngellusMortis/pyunifiprotect@v1.4.8...v1.5.3TODO for the rest of the UniFi Protect HACS migration after this PR:
ufp_value
-> lambda refactor (ref: Add UniFi Protect number platform聽#63220 (comment))Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: