Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Home Connect pre-rinse capability for a dishwasher #63536

Merged
merged 2 commits into from Mar 12, 2022
Merged

Add Home Connect pre-rinse capability for a dishwasher #63536

merged 2 commits into from Mar 12, 2022

Conversation

slovenec88
Copy link
Contributor

@slovenec88 slovenec88 commented Jan 6, 2022

Proposed change

Adds capability to send a pre-rinse command to a dishwasher.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant

This comment was marked as resolved.

@probot-home-assistant
Copy link

Hey there @DavidMStraub, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@homeassistant

This comment was marked as resolved.

@homeassistant
Copy link
Contributor

Hi @slovenec88,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine and the list is now a full match of the API which I found here:
https://api-docs.home-connect.com/programs-and-options?#dishwasher

Minor suggestion: All the rest of the items are listed in the exact order that they appear in the API doc, except this new one is at the top in the doc and you've added to the bottom in the PR (so I would suggest moving it to the top).

@homeassistant

This comment was marked as resolved.

@MartinHjelmare MartinHjelmare changed the title Home Connect: Add pre-rinse capability for a dishwasher Add Home Connect pre-rinse capability for a dishwasher Jan 6, 2022
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Jan 15, 2022
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 5, 2022
@slovenec88
Copy link
Contributor Author

May I please ask someone with write access to merge this? Thanks

@github-actions github-actions bot removed the stale label Feb 9, 2022
@davet2001
Copy link
Contributor

@slovenec88 Remember that you are in a growing queue of >400 PRs.

This one is really short so that should help. Maybe it can get a 'smash' label. But ultimately comes down to availability of the core devs.

@frenck frenck added smash Indicator this PR is close to finish for merging or closing cla-recheck and removed cla-signed cla-error labels Mar 12, 2022
Dev automation moved this from Needs review to Reviewer approved Mar 12, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @slovenec88 👍

@frenck frenck merged commit d41eeaa into home-assistant:dev Mar 12, 2022
Dev automation moved this from Reviewer approved to Done Mar 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: home_connect new-feature small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants