New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Home Connect pre-rinse capability for a dishwasher #63536
Add Home Connect pre-rinse capability for a dishwasher #63536
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hey there @DavidMStraub, mind taking a look at this pull request as it has been labeled with an integration ( |
This comment was marked as resolved.
This comment was marked as resolved.
Hi @slovenec88, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks fine and the list is now a full match of the API which I found here:
https://api-docs.home-connect.com/programs-and-options?#dishwasher
Minor suggestion: All the rest of the items are listed in the exact order that they appear in the API doc, except this new one is at the top in the doc and you've added to the bottom in the PR (so I would suggest moving it to the top).
This comment was marked as resolved.
This comment was marked as resolved.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
May I please ask someone with write access to merge this? Thanks |
@slovenec88 Remember that you are in a growing queue of >400 PRs. This one is really short so that should help. Maybe it can get a 'smash' label. But ultimately comes down to availability of the core devs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @slovenec88 👍
Proposed change
Adds capability to send a pre-rinse command to a dishwasher.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: