New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chime Type select for UniFi Protect #63993
Conversation
Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
@@ -45,6 +46,12 @@ | |||
{"id": IRLEDMode.OFF.value, "name": "Always Disable"}, | |||
] | |||
|
|||
CHIME_TYPES = [ | |||
{"id": ChimeType.NONE.value, "name": "None"}, | |||
{"id": ChimeType.MECHINCAL.value, "name": "Mechanical"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to fix this in pyunifiprotect (oops) in a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a much better UX 馃憤
I removed breaking change since technically nothing is a breaking change until after beta when this is officially released |
True. I am still going to be listed as a breaking change on the HACS side since it will be for anyone coming from HACS. |
Are there any docs changes for this one? |
Yeah, linked above. It is a one word change. |
Wow. Definitely need to get coffee before I look at anything else 馃檲 |
Proposed change
Replaces the "Chime Duration" number entity with a "Chime Type" select entity. UniFi Protect only uses 3 values for Chime Duration: 0, 300, and 1000. These map directly to the values None, Mechanical and Digital inside of the UniFi Protect UI.
Setting the value to other values may have unintended side-effects and we should stop allowing it.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: