Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chime Type select for UniFi Protect #63993

Merged
merged 2 commits into from Jan 12, 2022

Conversation

AngellusMortis
Copy link
Contributor

@AngellusMortis AngellusMortis commented Jan 12, 2022

Proposed change

Replaces the "Chime Duration" number entity with a "Chime Type" select entity. UniFi Protect only uses 3 values for Chime Duration: 0, 300, and 1000. These map directly to the values None, Mechanical and Digital inside of the UniFi Protect UI.

Setting the value to other values may have unintended side-effects and we should stop allowing it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@@ -45,6 +46,12 @@
{"id": IRLEDMode.OFF.value, "name": "Always Disable"},
]

CHIME_TYPES = [
{"id": ChimeType.NONE.value, "name": "None"},
{"id": ChimeType.MECHINCAL.value, "name": "Mechanical"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to fix this in pyunifiprotect (oops) in a followup.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a much better UX 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Jan 12, 2022
@bdraco
Copy link
Member

bdraco commented Jan 12, 2022

I removed breaking change since technically nothing is a breaking change until after beta when this is officially released

@AngellusMortis
Copy link
Contributor Author

AngellusMortis commented Jan 12, 2022

True. I am still going to be listed as a breaking change on the HACS side since it will be for anyone coming from HACS.

@bdraco
Copy link
Member

bdraco commented Jan 12, 2022

Are there any docs changes for this one?

@AngellusMortis
Copy link
Contributor Author

Yeah, linked above. It is a one word change.

@bdraco
Copy link
Member

bdraco commented Jan 12, 2022

Yeah, linked above. It is a one word change.

Wow. Definitely need to get coffee before I look at anything else 馃檲

@bdraco bdraco merged commit 6473069 into home-assistant:dev Jan 12, 2022
Dev automation moved this from Reviewer approved to Done Jan 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2022
@AngellusMortis AngellusMortis deleted the ufp-chime-type branch October 18, 2022 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants