New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup type hints (init) #64351
Add setup type hints (init) #64351
Conversation
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok rfxtrx
Are you happy with the latest changes @MartinHjelmare ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easier to just commit the suggested changes to guarantee it's done as wanted. That will also resolve the comments automatically.
Agreed. I just got mixed up with the mypy ignore PRs that I'm working on in parallel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Breaking change
Proposed change
As spotted in #64313 (CI run https://github.com/home-assistant/core/runs/4851145391?check_suite_focus=true)
This is 100% pure type hints - no code changes.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: