Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup type hints (init) #64351

Merged
merged 13 commits into from Jan 19, 2022
Merged

Add setup type hints (init) #64351

merged 13 commits into from Jan 19, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jan 18, 2022

Breaking change

Proposed change

As spotted in #64313 (CI run https://github.com/home-assistant/core/runs/4851145391?check_suite_focus=true)

This is 100% pure type hints - no code changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Jan 18, 2022
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok rfxtrx

@epenet epenet changed the title Add setup type hints Add setup type hints (1/2) Jan 18, 2022
@epenet epenet changed the title Add setup type hints (1/2) Add setup type hints (init) Jan 18, 2022
homeassistant/components/xiaomi_miio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/__init__.py Outdated Show resolved Hide resolved
@epenet
Copy link
Contributor Author

epenet commented Jan 19, 2022

Are you happy with the latest changes @MartinHjelmare ?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier to just commit the suggested changes to guarantee it's done as wanted. That will also resolve the comments automatically.

homeassistant/components/xiaomi_miio/__init__.py Outdated Show resolved Hide resolved
@epenet
Copy link
Contributor Author

epenet commented Jan 19, 2022

Agreed. I just got mixed up with the mypy ignore PRs that I'm working on in parallel.
I wanted to test your suggestions locally against mypy but in the end it turns out that xiaomi_miio is still in the mypy ignore list and my testing against mypy was completely pointless!!!

Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epenet epenet merged commit 250379e into home-assistant:dev Jan 19, 2022
@epenet epenet deleted the setup-type-hints branch January 19, 2022 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants