Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rachio from mypy ignore list #64521

Merged
merged 2 commits into from Jan 20, 2022
Merged

Remove rachio from mypy ignore list #64521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bcb653
Adjust rachio
epenet Jan 19, 2022
7826ba4
Adjust mypy-config
epenet Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions homeassistant/components/rachio/switch.py
View file
Open in desktop
Expand Up @@ -291,6 +291,7 @@ def _async_handle_update(self, *args, **kwargs) -> None:
endtime = parse_datetime(args[0][0][KEY_RAIN_DELAY_END])
_LOGGER.debug("Rain delay expires at %s", endtime)
self._state = True
assert endtime is not None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse_datetime can return None, but async_track_point_in_utc_time doesn't allow it

self._cancel_update = async_track_point_in_utc_time(
self.hass, self._delay_expiration, endtime
)
Expand Down
3 changes: 0 additions & 3 deletions mypy.ini
View file
Open in desktop
Expand Up @@ -2176,9 +2176,6 @@ ignore_errors = true
[mypy-homeassistant.components.profiler.*]
ignore_errors = true

[mypy-homeassistant.components.rachio.*]
ignore_errors = true

[mypy-homeassistant.components.ring.*]
ignore_errors = true

Expand Down
1 change: 0 additions & 1 deletion script/hassfest/mypy_config.py
View file
Open in desktop
Expand Up @@ -67,7 +67,6 @@
"homeassistant.components.plum_lightpad.*",
"homeassistant.components.point.*",
"homeassistant.components.profiler.*",
"homeassistant.components.rachio.*",
"homeassistant.components.ring.*",
"homeassistant.components.ruckus_unleashed.*",
"homeassistant.components.screenlogic.*",
Expand Down