New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running the KNX IP communication in a separate thread #64590
Conversation
Hey there @Julius2342, @farmio, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Tested locally, works perfectly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly wonder if we should even expose such "complex" features in the UI (or at all). 99% of the users won't have a clue what this even means.
That's why we hide it under |
I don't even agree with that. This is not a feature, this is internal logic, that should not be exposed to end-user at all (regardless of their knowledge level). |
Co-authored-by: Matthias Alphart <farmio@alphart.net>
It's an attempt to fix #59170. We do not want to roll this out to all users because the logic is quite complex and may have side effects that we were unable to test during our own test (as we also don't experience the mentioned error on our systems). Also, not all users experience the issue in mentioned ticket. If we can confirm that this logic works we can remove this again entirely and make it default. At least, so the plan. |
I see your point, but IMHO, these are options we should never expose. |
I got your point as well, but I don't see any alternative, IMHO it's not an option to roll out changes that might break stuff, especially if it's a fundamental change like this one that requires field testing with multiple devices - not only the two that @farmio and I have. Do you have a better idea? I'm open for it. |
@frenck I'll close this PR. We will revert the changes in the library. As spoken with bdraco we will focus on fixing the event loop blocks instead of just spawning a new thread for the connection logic. This will make this PR invalid anyway. |
Proposed change
Allow the users to run the communication with the KNX IP Interface to run in a separate thread in order to avoid #59170.
This is an experimental feature.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: