Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylint to pre-commit hooks #64665

Merged
merged 2 commits into from Jan 24, 2022

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jan 21, 2022

Proposed change

pylint was not part of the pre-commit hooks, so it often happens, that pylint issue are only detected by CI run, but not already during develeopment.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Jan 21, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been multiple attempts and PRs for this in the past.
pylint has been left out, mainly because of speed concerns and annoying experiences in wait time before committing.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 23, 2022
@frenck
Copy link
Member

frenck commented Jan 24, 2022

Tested this on a couple of changesets and in different setups. This works fine.
It limits Pylint nicely to only the changed files, making it run quite fast.

Let's add this and see how it goes.

Thanks, @mib1185 馃憤

@frenck frenck merged commit a5eac99 into home-assistant:dev Jan 24, 2022
@mib1185 mib1185 deleted the add-pylint-to-pre-commit branch January 24, 2022 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants