Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UniFi bandwidth sensors be about current transfer rather than total transfer #64701

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jan 22, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 force-pushed the unifi-bandwidth_sensors_should_use_current_transfer_not_total_transfer branch from bf65990 to 467bf9f Compare January 22, 2022 12:45
@Kane610 Kane610 added integration: unifi small-pr PRs with less than 30 lines. labels Jan 22, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 23, 2022
Copy link
Contributor

@austinmroczek austinmroczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should consider renaming the *BandwidthSensor classes since the sensors measure MB, not MB/s.

@emontnemery emontnemery merged commit 597fca9 into home-assistant:dev Jan 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
@Kane610 Kane610 deleted the unifi-bandwidth_sensors_should_use_current_transfer_not_total_transfer branch September 29, 2023 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: unifi small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unifi: bandwidth entity is actually accumulated transfer
5 participants