Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Renault to 0.1.7 #65076

Merged
merged 2 commits into from Jan 27, 2022
Merged

Update Renault to 0.1.7 #65076

merged 2 commits into from Jan 27, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jan 27, 2022

Proposed change

This release fixes an issue where the hvac vehicle status is not available when it should be (see hacf-fr/renault-api#452)

Release notes: https://github.com/hacf-fr/renault-api/releases/tag/v0.1.7
Full diff: hacf-fr/renault-api@v0.1.4...v0.1.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jan 27, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 27, 2022
@epenet
Copy link
Contributor Author

epenet commented Jan 27, 2022

I think this dependency bump should be included in 2022.2

@frenck frenck added this to the 2022.2.0 milestone Jan 27, 2022
@epenet
Copy link
Contributor Author

epenet commented Jan 27, 2022

cc @ZMan88

frenck
frenck approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Jan 27, 2022
@frenck
Copy link
Member

frenck commented Jan 27, 2022

Seems to return additional data now

@ZMan88
Copy link

ZMan88 commented Jan 27, 2022

Thanks @epenet

@epenet epenet merged commit d706a7b into home-assistant:dev Jan 27, 2022
Dev automation moved this from Reviewer approved to Done Jan 27, 2022
@epenet epenet deleted the bump-renault branch January 27, 2022 19:19
balloob pushed a commit that referenced this pull request Jan 27, 2022
@epenet @balloob
Update Renault to 0.1.7 (#65076)
ff445b6 
* Update Renault to 0.1.7

* Adjust tests accordingly

Co-authored-by: epenet <epenet@users.noreply.github.com>
@epenet epenet mentioned this pull request Jan 27, 2022
Closed
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency dependency-bump integration: renault small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
2022.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@epenet @frenck @ZMan88 @balloob @homeassistant