Add a base class for Intellifire entities

[jeeftor]

Breaking change

Proposed change

@epenet suggested I make a shared common entity.py class. This is a PR attempting to do this :) I'm not sure I 100% did this the cleanest way possible but hopefully we can fix that during the review process.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[epenet]

Here are a few comments and suggestions to help you get started.

[jeeftor]

Testing the new changes locally now..

They work!

[epenet]

A few extra tweaks.

And since you are reordering things already in sensor.py I would reorder them instead to have this order:

1. dataclasses (IntellifireSensorRequiredKeysMixin/IntellifireSensorEntityDescription)
2. descriptions (INTELLIFIRE_SENSORS)
3. private functions (_time_remaining_to_timestamp)
4. main setup (async_setup_entry)
5. entity classes (IntellifireSensor)

[epenet]

I forgot to tick "request changes" in the review - please look above for the requested changes.

[jeeftor]

A few extra tweaks.

And since you are reordering things already in sensor.py I would reorder them instead to have this order:

1. dataclasses (IntellifireSensorRequiredKeysMixin/IntellifireSensorEntityDescription)
2. descriptions (INTELLIFIRE_SENSORS)
3. private functions (_time_remaining_to_timestamp)
4. main setup (async_setup_entry)
5. entity classes (IntellifireSensor)

So I tried to do this BUT!!!!:

When I have the _time_remaining_to_timestamp after the INTELLIFIRE_SENSORS I get the warning as seen here...

And then when I try to run this code I get the following:

As I understand (unlike say C) there is no way to do forward declarations in python ... so I'm sure you can suggest a cool "clean" pythonic way of obtaining this order :)

[epenet]

A few extra tweaks.
And since you are reordering things already in sensor.py I would reorder them instead to have this order:

1. dataclasses (IntellifireSensorRequiredKeysMixin/IntellifireSensorEntityDescription)
2. descriptions (INTELLIFIRE_SENSORS)
3. private functions (_time_remaining_to_timestamp)
4. main setup (async_setup_entry)
5. entity classes (IntellifireSensor)

So I tried to do this BUT!!!!:

When I have the _time_remaining_to_timestamp after the INTELLIFIRE_SENSORS I get the warning as seen here...

And then when I try to run this code I get the following:

As I understand (unlike say C) there is no way to do forward declarations in python ... so I'm sure you can suggest a cool "clean" pythonic way of obtaining this order :)

Ah yes you have to invert 2 and 3

[jeeftor]

Everything should be ordered accordingly.... :)

[jeeftor]

@epenet / @frenck -> I want to make an additional PR based on this codebase. It's not yet merged into dev branch - what approach should I take?

• Branch off this codebase?
• Wait for it to be merged back into Dev?
• Make mods to this branch?

I'm assuming that the best approach is to wait until this code is merged into dev