New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuya fan percentage fix #65225
Tuya fan percentage fix #65225
Conversation
Hey there @tuya, @zlinoliver, @METISU, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @fOmey 馃憤
This makes a lot of sense in case e.g., 6 speeds are communicated as a percentage (of which we now know, Tuya does).
Breaking change
Proposed change
Add "natural wind" mode to tuya fans & calculate speed percentage range with a minimum value of 1.
Natural wind being a pulsing fan mode.
0% as a speed percentage is invalid for fs & fsd.
Without these changes the lowest fan speed is displayed as 0% on the slider.. more importantly this causes a undesired effect of the fan turning off when trying to enter the slowest speed setting. In the case of
fs
, setting a speed percent between 1-16% turns off the fan.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: