Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuya fan percentage fix #65225

Merged
merged 4 commits into from Jan 31, 2022
Merged

Tuya fan percentage fix #65225

merged 4 commits into from Jan 31, 2022

Conversation

fOmey
Copy link
Contributor

@fOmey fOmey commented Jan 30, 2022

Breaking change

Proposed change

Add "natural wind" mode to tuya fans & calculate speed percentage range with a minimum value of 1.

Natural wind being a pulsing fan mode.

0% as a speed percentage is invalid for fs & fsd.

Without these changes the lowest fan speed is displayed as 0% on the slider.. more importantly this causes a undesired effect of the fan turning off when trying to enter the slowest speed setting. In the case of fs, setting a speed percent between 1-16% turns off the fan.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@fOmey fOmey requested a review from frenck as a code owner January 30, 2022 05:47
@project-bot project-bot bot added this to Needs review in Dev Jan 30, 2022
@probot-home-assistant
Copy link

Hey there @tuya, @zlinoliver, @METISU, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Review in progress Jan 30, 2022
@fOmey fOmey requested a review from frenck January 30, 2022 09:05
@frenck frenck added this to the 2022.2.0 milestone Jan 31, 2022
@frenck frenck changed the title Tuya fan percentage fix & natural wind mode Tuya fan percentage fix Jan 31, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fOmey 馃憤

This makes a lot of sense in case e.g., 6 speeds are communicated as a percentage (of which we now know, Tuya does).

Dev automation moved this from Review in progress to Reviewer approved Jan 31, 2022
@frenck frenck merged commit 9b5757d into home-assistant:dev Jan 31, 2022
Dev automation moved this from Reviewer approved to Done Jan 31, 2022
@fOmey fOmey deleted the tuya-fs branch January 31, 2022 19:33
balloob pushed a commit that referenced this pull request Feb 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants