Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aladdin_connect to 0.4 to fix integration for some users due to API changes #65407

Merged
merged 1 commit into from Feb 2, 2022
Merged

Bump aladdin_connect to 0.4 to fix integration for some users due to API changes #65407

merged 1 commit into from Feb 2, 2022

Conversation

shoejosh
Copy link
Contributor

@shoejosh shoejosh commented Feb 2, 2022

Proposed change

Fixes #58946

Aladdin has changed their API and some (not all) devices no longer work with the old API. My device works with the old API but also works with the new API so the assumption is all devices would work with the new API.

aladdin_connect module has been updated to use the new API - https://github.com/shoejosh/aladdin-connect/releases/tag/0.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shoejosh 👍

@frenck frenck merged commit 4a55d58 into home-assistant:dev Feb 2, 2022
@shoejosh shoejosh deleted the aladdin_connect_bump branch February 2, 2022 13:36
frenck pushed a commit that referenced this pull request Feb 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genie Aladdin integration broken
3 participants