Code Quality improvements for Aussie Broadband #65408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: aussie_broadband
small-pr
|
Hey there @nickw444, mind taking a look at this pull request as it has been labeled with an integration ( |
22 tasks
frenck
added
the
smash
MartinHjelmare
requested changes
Feb 16, 2022
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
| @@ -229,7 +186,7 @@ async def test_reauth(hass: HomeAssistant) -> None: | |||
| context={"source": config_entries.SOURCE_REAUTH}, | |||
| data=FAKE_DATA, | |||
| ) | |||
| assert result5["step_id"] == "reauth" | |||
| assert result5["step_id"] == "reauth_confirm" | |||
|
|
|||
| with patch("aussiebb.asyncio.AussieBB.__init__", return_value=None), patch( | |||
There was a problem hiding this comment.
This patch (and similar) still looks weird, but we can address that in a separate PR.
There was a problem hiding this comment.
Yeah I expected we may need to discuss this further. I tried removing the init patch and things broke. Now that the library has been bumped, I think I will be able to do a PR focusing on tests.
There was a problem hiding this comment.
It should be enough to patch "homeassistant.components.aussie_broadband.config_flow.AussieBB.login" and the same for "get_services".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This primarily addresses issues raised here #53552 (review)
I am expecting additional feedback about the test cases.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: