Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Advantage Air to 0.2.6 #65849

Merged
merged 1 commit into from Feb 5, 2022
Merged

Bump Advantage Air to 0.2.6 #65849

merged 1 commit into from Feb 5, 2022

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Feb 5, 2022

Proposed change

Bump Advantage Air library to fix fan mode issue with MyAir5 systems #62362

Changes: Bre77/advantage_air@d0e0265

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@thecode
Copy link
Member

thecode commented Feb 5, 2022

Strange there are no labels on this PR and you are not tagged as code owner

@thecode thecode merged commit f4eb7e3 into home-assistant:dev Feb 5, 2022
@project-bot project-bot bot added this to Needs review in Dev Feb 6, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 6, 2022
@Bre77 Bre77 deleted the aa-0.2.6 branch February 6, 2022 02:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2022
@balloob balloob added this to the 2022.2.7 milestone Feb 16, 2022
@MartinHjelmare MartinHjelmare moved this from By Code Owner to Done in Dev Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Advantage Air myfan Auto not in sync
4 participants