Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tplink hardware version to device info #65951

Merged
merged 2 commits into from Feb 6, 2022

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Feb 6, 2022

Proposed change

Adds hardware version to tplink device info.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: tplink small-pr PRs with less than 30 lines. labels Feb 6, 2022
@project-bot project-bot bot added this to Needs review in Dev Feb 6, 2022
@probot-home-assistant
Copy link

Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Member

bdraco commented Feb 6, 2022

Looks like its safe to assume its there 馃憤

bdraco@MacBook-Pro-4 fixtures % git grep sw_ver|wc
      52     312    4039
bdraco@MacBook-Pro-4 fixtures % git grep hw_ver|wc
      52     156    2697

Dev automation moved this from Needs review to Reviewer approved Feb 6, 2022
@bdraco
Copy link
Member

bdraco commented Feb 6, 2022

Screen Shot 2022-02-06 at 16 24 44

@thecode thecode merged commit f4ebb03 into home-assistant:dev Feb 6, 2022
Dev automation moved this from Reviewer approved to Done Feb 6, 2022
@rytilahti rytilahti deleted the tplink/feat/add_hw_version branch February 6, 2022 23:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants