New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Make idle chromecasts appear as idle instead of off" #66005
Conversation
This reverts commit 0998643.
Is that reversion gonna break the ability to change volume on google home devices while not playing anything? at least that was a big improvement from the previous change, I don't want to loose that. |
Can we make this an option and let users decide? I liked the fact that the true status was shown ie"backdrop' when not actually off. And, as @sdrapha said, we can no longer set volumes prior use with an 'off' status. Thank You |
I second @sdrapha @pgsylvestre I have always missed the ability to change the volume without actually turning on the google home device. I was very happy when we were finally able to do it. |
I don't agree with the argument that with the state always being entity_id: media_player.slaapkamer_hub
state: idle volume_level: 0.25
is_volume_muted: false
media_content_id: some.mp3
media_duration: 61.584
media_position: 0
media_position_updated_at: '2022-02-09T13:58:07.849872+00:00'
media_title: 14 - Jongens, Meisjes, Aan De Kant - 62
app_id: CC1AD845
app_name: Default Media Receiver
entity_picture_local: some.jpg
entity_picture: /local/pictures/tags/bijt_ie_in_je_bil.jpg
friendly_name: Slaapkamer Hub
supported_features: 152463 There were also really nice advantages of the player being able, as you could always change volume, or retrieve attributes like the |
I agree with the need to control the volume, but I also understand the concerns raised in #65853 |
Reverts #61786
The change is not good because chrome casts running an app but not playing media can no lonegr be distinguished from chromecasts not running any app.
We should probably add a new state "Running app" or similar to the base
MediaPlayerEntity
Fixes: #65853