Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Sonos activity monitoring #66207

Merged
merged 2 commits into from Feb 10, 2022

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented Feb 9, 2022

Proposed change

Various tweaks to the availability checks used in Sonos:

  • Support new sleeping vanish reason
  • Check availability before last-ditch check
  • Use short-timeout call for last-ditch check, only check for network-related exceptions
  • Adjust reboot logging message and severity

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (sonos) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Feb 9, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 9, 2022
@jjlawren jjlawren marked this pull request as ready for review February 9, 2022 20:29
@jjlawren jjlawren requested a review from cgtobi as a code owner February 9, 2022 20:29
* Support new 'sleeping' vanish reason
* Check availability before last-ditch check
* Use short-timeout call for last-ditch check
* Adjust reboot logging message and severity
@jjlawren jjlawren force-pushed the sonos_tweak_availability_checks branch from 25093f6 to 43ebeb0 Compare February 10, 2022 04:03
@jjlawren jjlawren marked this pull request as draft February 10, 2022 04:05
@jjlawren jjlawren marked this pull request as ready for review February 10, 2022 06:23
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

homeassistant/components/sonos/speaker.py Show resolved Hide resolved
Dev automation moved this from By Code Owner to Reviewer approved Feb 10, 2022
@Kane610
Copy link
Member

Kane610 commented Feb 10, 2022

LGTM?!

@jjlawren jjlawren merged commit e86c82e into home-assistant:dev Feb 10, 2022
Dev automation moved this from Reviewer approved to Done Feb 10, 2022
@jjlawren jjlawren deleted the sonos_tweak_availability_checks branch February 10, 2022 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants