Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tradfri device name #66219

Merged
merged 1 commit into from Feb 10, 2022
Merged

Conversation

ggravlingen
Copy link
Contributor

@ggravlingen ggravlingen commented Feb 9, 2022

Proposed change

This PR implements the fix suggested here:
#66119 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: tradfri small-pr PRs with less than 30 lines. labels Feb 9, 2022
@project-bot project-bot bot added this to Needs review in Dev Feb 9, 2022
@ggravlingen ggravlingen marked this pull request as ready for review February 9, 2022 20:27
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Feb 9, 2022
@MartinHjelmare MartinHjelmare changed the title Fix for issue #66119 in Tradfri platform Fix tradfri device name Feb 10, 2022
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 543b497 into home-assistant:dev Feb 10, 2022
Dev automation moved this from Reviewer approved to Done Feb 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2022
@ggravlingen ggravlingen deleted the fix_66119 branch April 5, 2022 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Tradfri device Air purifier is named ..'filter time left'
4 participants