Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial xiaomi_miio support for dmaker.airfresh.a1/t2017 #66331

Merged
merged 2 commits into from Feb 11, 2022
Merged

Initial xiaomi_miio support for dmaker.airfresh.a1/t2017 #66331

merged 2 commits into from Feb 11, 2022

Conversation

Kirmas
Copy link
Contributor

@Kirmas Kirmas commented Feb 11, 2022

Proposed change

This PR add two new device to xiaomi_miio integration dmaker.airfresh.a1 and dmaker.airfresh.t2017
This is initial PR I tried add as less new entities as i can due to this message. After this PR will be merged i`ll add more entities platform by platform.
FR: https://community.home-assistant.io/t/support-for-xiaomi-miio-support-for-dmaker-airfresh-t2017/235798

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Feb 11, 2022
@Kirmas
Copy link
Contributor Author

Kirmas commented Feb 11, 2022

@MartinHjelmare is this more correct?

@MartinHjelmare
Copy link
Member

Looks ok to me. A codeowner should review too.

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this so let's merge it. Thanks for the PR @Kirmas!

@Kirmas as you have a better understanding of the integration and this type of devices, would you be up for some brainstorming to create a generic interface inside python-miio, and to start moving device specific parts (available features, available modes, ..) towards upstream?

Dev automation moved this from Needs review to Reviewer approved Feb 11, 2022
@rytilahti rytilahti changed the title Initial support for dmaker.airfresh.a1/t2017 Initial xiaomi_miio support for dmaker.airfresh.a1/t2017 Feb 11, 2022
@rytilahti rytilahti merged commit 2ffb46d into home-assistant:dev Feb 11, 2022
Dev automation moved this from Reviewer approved to Done Feb 11, 2022
@Kirmas Kirmas deleted the add_dmaker_airfresh_part_1 branch February 12, 2022 06:40
@Kirmas
Copy link
Contributor Author

Kirmas commented Feb 12, 2022

@Kirmas as you have a better understanding of the integration and this type of devices, would you be up for some brainstorming to create a generic interface inside python-miio, and to start moving device specific parts (available features, available modes, ..) towards upstream?

I have added this to my personal TO-Do list. But It could be a lot of work (I must analyze other fan devices because looks like some things inside airfresh_t2017.py looks differently and could be standardize.). if you dont mind I`ll do this refactoring step after this integration will be finished.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants