Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change in vizio logic to fix bug #66424

Merged
merged 1 commit into from Feb 14, 2022
Merged

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Feb 13, 2022

Proposed change

Should resolve the issues that were mentioned in #65612 as a result of #64025

Note: this does not require a patch release but if a patch release happens, this should go with it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@raman325 raman325 added this to the 2022.2.7 milestone Feb 13, 2022
@MartinHjelmare MartinHjelmare changed the title revert change in vizio logic to fix bug Revert change in vizio logic to fix bug Feb 13, 2022
@thecode thecode merged commit 051bf17 into home-assistant:dev Feb 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
@raman325 raman325 deleted the bug_fix branch February 16, 2022 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer possible to map HDMI inputs to App Names
5 participants