Fix translation typing

[cdce8p]

Proposed change

The return type for _build_resources should be changed to dict[str, dict[str, Any] | str], since not all dictionary values are itself dictionaries. For example

core/homeassistant/components/light/translations/en.json

Line 28 in 4c5d647

"title": "Light"

_build_category_cache already has code to handle that case.

core/homeassistant/helpers/translation.py

Lines 270 to 278 in 4c5d647

	if isinstance(resource, dict):
	category_cache.update(
	recursive_flatten(
	f"component.{component}.{category}.",
	resource,
	)
	)
	else:
	category_cache[f"component.{component}.{category}"] = resource

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[balloob]

Shouldn't this be able to be referenced from translation_strings? And so we should update the type of the translation-strings param instead?

[cdce8p]

The type for translation_strings is correct as far as I can tell. Any is basically dict[str, Any] | str there.

Shouldn't this be able to be referenced from translation_strings?

Yeah it is, but that's also the issue. Just from translation_strings, resource would be typed as dict[str, Any] and thus wouldn't allow str. The alternative would be to rename resource in the third for loop to something like resource2. That would allow for dedicated types.

Otherwise, we need the type definition here. The type inference still works like you would expect it to. I.e. inside the first the for ... translation_strings.values() block, resource is only dict[str, Any].

[balloob]

Is this the preferred approach over casting?

[cdce8p]

I think type: ignore with a type definition is slightly better here.
Once mypy is able to infer resource_func correctly, we could just remove the comment. With cast we wouldn't even know that's the case, since the inferred type will be different from, but compatible with Mapping.

dict[str, dict[str, Any]]  |  dict[str, dict[str, Any] | str]