Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary sensor translations for carbon_monoxide #66891

Merged
merged 3 commits into from Feb 21, 2022

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Feb 19, 2022

Proposed change

While developing a custom component, I noticed that the state key for carbon_monoxide in strings.json is not correct.

Before:
Screen Shot 2022-02-19 at 00 51 16

After:
Screen Shot 2022-02-19 at 01 17 25

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Comment on lines 196 to 197
"off": "[%key:common::state::not_home%]",
"on": "[%key:common::state::home%]"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this change after running:
python3 -m script.translations develop --integration binary_sensor

Happy to revert manually, but would be good to understand if I need to run another command.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug in our resolving script unable to handle double references. Pushed a fix.

@frenck frenck requested a review from balloob February 21, 2022 17:18
@frenck
Copy link
Member

frenck commented Feb 21, 2022

I don't see why, @balloob, pardon the ping. But you know most about this part.

Dev automation moved this from Needs review to Reviewer approved Feb 21, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @iMicknl & @balloob 馃憤

@balloob balloob merged commit 5af4068 into home-assistant:dev Feb 21, 2022
Dev automation moved this from Reviewer approved to Done Feb 21, 2022
@iMicknl iMicknl deleted the fix/binary_sensor_translations branch February 21, 2022 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants