New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binary sensor translations for carbon_monoxide #66891
Fix binary sensor translations for carbon_monoxide #66891
Conversation
"off": "[%key:common::state::not_home%]", | ||
"on": "[%key:common::state::home%]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this change after running:
python3 -m script.translations develop --integration binary_sensor
Happy to revert manually, but would be good to understand if I need to run another command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug in our resolving script unable to handle double references. Pushed a fix.
I don't see why, @balloob, pardon the ping. But you know most about this part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed change
While developing a custom component, I noticed that the state key for carbon_monoxide in strings.json is not correct.
Before:
After:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: