Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fan template loosing percentage/preset #67648

Merged
merged 2 commits into from Mar 4, 2022
Merged

Fix Fan template loosing percentage/preset #67648

merged 2 commits into from Mar 4, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 4, 2022

Proposed change

Fixes an issue reported in #67266.

Template fans update their preset/percentage based on template changes (e.g., a used entity in that template changes). However, in the current situation, when turning off a template fan, it will also reset the internal preset/percentage values.

This causes issues when turning on the fan later, as it would have reset preset/percentage, which isn't corrected until the template rendering re-triggers.

This change makes it behave consistently and as expected.

2022-03-03 15 09 22

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@frenck frenck added this to the 2022.3.2 milestone Mar 4, 2022
@frenck frenck requested a review from a team as a code owner March 4, 2022 15:56
@probot-home-assistant
Copy link

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Member

bdraco commented Mar 4, 2022

This is safe now that we dropped the legacy fan speeds

#67266 (comment)

@frenck frenck merged commit cb1299b into dev Mar 4, 2022
@frenck frenck deleted the frenck-2022-0511 branch March 4, 2022 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fan.turn_on not behaving in expected way
4 participants