Skip unsupported LIFX Switches during discovery

[Djelibeybi]

This resolves an issue with the underlying library waiting for
a response from the switches that will never arrive.

Signed-off-by: Avi Miller me@dje.li

Proposed change

This change adjusts the discovery of LIFX devices so that switches are skipped. This is due to the underlying aiolifx library's lack of support for switches and the core integration's assumption that all LIFX devices are bulbs. The bulb.get_color call will hang for about 2-3 minutes for each switch discovered without this fix.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Issue with Lifx integration #57195
• This PR is related to issue: Lifx Bulbs/Strips Stepping #54440 (possibly)
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• [-] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [-] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [-] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [-] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [-] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [-] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[bdraco]

It would be cleaner if the library provided this in the future.

[Djelibeybi]

It would be even better if the library supported the Switch.

[frenck]

Chill, I'm merely asking on an ETA.

There is no ETA. Please just be patient. Thanks 👍

Let's keep comments on PR towards the actual review as well. If you have further/other questions, please use our community forum or Discord chat.

../Frenck

[frenck]

Thanks, @Djelibeybi 👍

[Djelibeybi]

You're welcome @frenck.

If I may: the LIFX integration is showing its age and needs more than a little bit of love. Where's the right place to discuss what's required and how best to implement those requirements? In particular, I'd be keen to replace the underlying library used, and I'd love to get feedback from others.

[frenck]

@Djelibeybi Well, you can show it some love by opening PRs of course :)

For the library, I think it is always best (for the whole Python ecosystem) to discuss library changes with the current maintainer of the library.

If you have further questions in general, please feel free to join our Discord chat.

../Frenck

[Djelibeybi]

Great, thanks.