Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor platform to Kaleidescape #67884

Merged
merged 6 commits into from Mar 10, 2022

Conversation

SteveEasley
Copy link
Contributor

@SteveEasley SteveEasley commented Mar 8, 2022

Proposed change

Add sensor platform to new Kaleidescape integration (#67711).

Also bumped the library dependency to address feedback in this PR. https://github.com/SteveEasley/pykaleidescape/releases/tag/v1.0.1.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Mar 9, 2022

It looks like this integration might also be a media source (there isn't much documentation available on this yet)

Examples

camera/media_source.py		jellyfin/media_source.py	nest/media_source.py		radio_browser/media_source.py	xbox/media_source.py
dlna_dms/media_source.py	motioneye/media_source.py	netatmo/media_source.py		tts/media_source.py

@SteveEasley
Copy link
Contributor Author

It looks like this integration might also be a media source (there isn't much documentation available on this yet)

Yeah looks pretty cool. Definitely plan to implement this shortly after a release when I get more time.

@SteveEasley SteveEasley closed this Mar 9, 2022
@SteveEasley SteveEasley reopened this Mar 9, 2022
@bdraco
Copy link
Member

bdraco commented Mar 10, 2022

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.
    This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks 馃憤

@SteveEasley
Copy link
Contributor Author

Description is now updated with link to release notes.

@bdraco
Copy link
Member

bdraco commented Mar 10, 2022

Should be good to go once a docs PR is opened to add the sensor platform

@SteveEasley
Copy link
Contributor Author

SteveEasley commented Mar 10, 2022

PR created home-assistant/home-assistant.io#21957.

Also head up, I am adding one final PR for a remote platform for this integration. Code is done, adding PR after this one is merged.

@bdraco
Copy link
Member

bdraco commented Mar 10, 2022

Please update the docs link in the opening text to point to the new docs PR. Thanks (I'd do it for you but I'm boarding a flight and can't edit on my phone)

@SteveEasley
Copy link
Contributor Author

Done. Wow you get around lol. Safe travels.

@bdraco bdraco merged commit ab4aa83 into home-assistant:dev Mar 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants