Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyisy to 3.0.5 #68069

Merged
merged 2 commits into from
Mar 13, 2022
Merged

Bump pyisy to 3.0.5 #68069

merged 2 commits into from
Mar 13, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 13, 2022

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2022.3.5 milestone Mar 13, 2022
@project-bot project-bot bot added this to Needs review in Dev Mar 13, 2022
@probot-home-assistant
Copy link

Hey there @shbatm, mind taking a look at this pull request as it has been labeled with an integration (isy994) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 13, 2022
@bdraco
Copy link
Member Author

bdraco commented Mar 13, 2022

Looks like the publish failed for 3.0.4 for some reason. Will mark this as a draft while its sorted.

@bdraco bdraco marked this pull request as draft March 13, 2022 00:35
@shbatm
Copy link
Contributor

shbatm commented Mar 13, 2022

@bdraco Update to use V3.0.5; package action errored on V3.0.4.

@bdraco bdraco changed the title Bump pyisy to 3.0.4 Bump pyisy to 3.0.5 Mar 13, 2022
@bdraco bdraco marked this pull request as ready for review March 13, 2022 10:55
Dev automation moved this from By Code Owner to Reviewer approved Mar 13, 2022
@thecode thecode merged commit bfb8765 into home-assistant:dev Mar 13, 2022
Dev automation moved this from Reviewer approved to Done Mar 13, 2022
@bdraco
Copy link
Member Author

bdraco commented Mar 14, 2022

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Websocket issues with ISY integration (possible climate issue?)
5 participants