Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocketTimeoutException in SamsungTV #68114

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Mar 14, 2022

Proposed change

Fix WebSocketTimeoutException in SamsungTV.
It seems that some TVs simply do not reply to the app_list command.

⚠️ This is targetted against rc branch because samsungtv has been fully refactored to async for 2022.4, using a different package to communicate with the websocket.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet epenet added this to the 2022.3.5 milestone Mar 14, 2022
@epenet epenet requested a review from chemelli74 as a code owner March 14, 2022 08:56
@probot-home-assistant probot-home-assistant bot added bugfix integration: samsungtv merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Mar 14, 2022
@probot-home-assistant
Copy link

Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Mar 14, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 14, 2022
Dev automation moved this from By Code Owner to Reviewer approved Mar 14, 2022
@balloob balloob merged commit c086093 into home-assistant:rc Mar 14, 2022
Dev automation moved this from Reviewer approved to Done Mar 14, 2022
@epenet epenet deleted the fix-app-list branch March 14, 2022 16:32
@balloob balloob mentioned this pull request Mar 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cherry-picked cla-signed integration: samsungtv merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants