New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inverter size to Forecast.Solar #68263
Add inverter size to Forecast.Solar #68263
Conversation
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( |
Thanks for working on this! How would this work for systems that have two or more strings in different directions? For example, I have two forecast integrations setup, one for my east array and one for my west array. However, they both share the same 7.6 kW inverter. Seems like we might need something more "global"? |
I don't really have an answer to that at the moment, since it is a fairly specific situation that is not directly taken into account from the API. But maybe the community forum is a better place to talk about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @klaasnicolaas 馃憤
Small comment to remove space from a key (I noticed we do that for module power as well, but let's ignore that for now... can't change that without migration).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @klaasnicolaas 馃憤
Proposed change
Adds the ability to Forecast.Solar to specify an inverter size in watts.
This required updating the python package to: 2.2.0
https://github.com/home-assistant-libs/forecast_solar/releases/tag/2.2.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: