Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverter size to Forecast.Solar #68263

Merged
merged 4 commits into from Mar 23, 2022

Conversation

klaasnicolaas
Copy link
Member

@klaasnicolaas klaasnicolaas commented Mar 16, 2022

Proposed change

Adds the ability to Forecast.Solar to specify an inverter size in watts.
This required updating the python package to: 2.2.0

https://github.com/home-assistant-libs/forecast_solar/releases/tag/2.2.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (forecast_solar) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Mar 16, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 16, 2022
@klaasnicolaas klaasnicolaas changed the title Klaas/forecast update Add inverter size to Forecast.Solar Mar 16, 2022
@craigcabrey
Copy link

Thanks for working on this!

How would this work for systems that have two or more strings in different directions? For example, I have two forecast integrations setup, one for my east array and one for my west array. However, they both share the same 7.6 kW inverter.

Seems like we might need something more "global"?

@klaasnicolaas
Copy link
Member Author

I don't really have an answer to that at the moment, since it is a fairly specific situation that is not directly taken into account from the API. But maybe the community forum is a better place to talk about this.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 22, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @klaasnicolaas 馃憤
Small comment to remove space from a key (I noticed we do that for module power as well, but let's ignore that for now... can't change that without migration).

homeassistant/components/forecast_solar/const.py Outdated Show resolved Hide resolved
homeassistant/components/forecast_solar/strings.json Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Review in progress Mar 22, 2022
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Mar 22, 2022
Dev automation moved this from Review in progress to Reviewer approved Mar 23, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @klaasnicolaas 馃憤

@frenck frenck merged commit 0c45241 into home-assistant:dev Mar 23, 2022
Dev automation moved this from Reviewer approved to Done Mar 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2022
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed dependency has-tests integration: forecast_solar new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants