New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aladdin connect config flow #68304
Conversation
…aladdin_connect
This comment was marked as outdated.
This comment was marked as outdated.
You should an import flow, so that existing YAML configurations are automatically imported into a new config entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yaml config import is required when moving to a Config Flow. Please look at other integrations that have an import step to see how it is done.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Any pointers to an example? I can't seem to find one :( |
https://github.com/home-assistant/core/blob/dev/homeassistant/components/sensibo/climate.py#L84-L93 |
@gjohansson-ST Thanks for the references, works like a charm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's coming together nicely.
There's a LOT to learn... actual running code appears to only be 30% of the job :) |
One more question related to the reauth flow. In working out the lint error, I removed this from my version. I think that's a pointer to the entry.data (or it's the values already in the data?), but I don't believe my integration uses it if it's a pointer... I don't see anything similar in the example code. I guess the question is: did I do that right? :) |
You changed it to this instead which results in the same thing here now when you specify both username and password. **self.entry.data refer to entire dict so you only need to specify the changes but for only two key's it should be fine to specify them as you did now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some bits and pieces.
Seems close to done
I believe CI errors are because of a needed rebase? Looks like stuff that failed is not part of this change? Try again? |
Congratulations @mkmer 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments in a new PR. Thanks!
Breaking change
The aladdin_connect integration migrated to configuration via the UI. Configuring aladdin_conenct via YAML configuration has been deprecated and will be removed in a future Home Assistant release.
Your existing YAML configuration is automatically imported on upgrade to this release; and thus can be safely removed from your YAML configuration after upgrading.
single step config flow:
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: