Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI file changed filter #68351

Merged
merged 2 commits into from Mar 20, 2022
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Mar 18, 2022

Proposed change

Noticed that changes to a file in an integration subfolder caused a full CI run.
zha/core/groups.py -> #68350 - https://github.com/home-assistant/core/actions/runs/2006792841

The glob pattern only checked files directly inside an integration folder.

homeassistant/components/${integration}/*
tests/components/${integration}/*

I've also updated .core_files to use .../**, since some like mqtt do use subfolders.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 18, 2022
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Mar 18, 2022
@cdce8p cdce8p requested a review from frenck March 18, 2022 23:25
@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Mar 19, 2022
Dev automation moved this from Needs review to Reviewer approved Mar 20, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 馃憤

@frenck frenck merged commit e09d0b7 into home-assistant:dev Mar 20, 2022
Dev automation moved this from Reviewer approved to Done Mar 20, 2022
@cdce8p cdce8p deleted the fix-ci-file-changes branch March 20, 2022 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants