Support for zwave light transitions #6868
Conversation
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen, @balloob and @leoc to be potential reviewers. |
| @@ -72,6 +72,13 @@ def brightness_state(value): | |||
| return 0, STATE_OFF | |||
|
|
|||
|
|
|||
| def ct_to_rgb(temp): | |||
There was a problem hiding this comment.
Unrelated, but I just moved this up so it's not in-between the two classes.
| return | ||
|
|
||
| if ATTR_TRANSITION not in kwargs: | ||
| self.values.dimming_duration.data = 0xFF |
There was a problem hiding this comment.
Could you check in OZW_Log.txt if this assignment causes a zwave message to be sent when data doesn't actually changes? (i.e. it was already 0xFF)
There was a problem hiding this comment.
Yeah, I'll take a look, but at least from a theoretical level it shouldn't. The dimming duration is actually just a parameter that gets sent with the multilevel switch set command.
There was a problem hiding this comment.
Here it is. You can see where the dimming_duration is part of the SwitchMultilevelCmd_Set message to the network.
2017-04-01 15:41:20.398 Info, Node003, Value::Set - COMMAND_CLASS_SWITCH_MULTILEVEL - Dimming Duration - 5 - 1 - \FF
2017-04-01 15:41:20.398 Detail, Node003, Refreshed Value: old value=255, new value=255, type=byte
2017-04-01 15:41:20.398 Detail, Node003, Changes to this value are not verified
2017-04-01 15:41:20.398 Detail, Node003, Notification: ValueChanged
2017-04-01 15:41:20.398 Info, Node003, Value::Set - COMMAND_CLASS_SWITCH_MULTILEVEL - Level - 0 - 1 -
2017-04-01 15:41:20.398 Info, Node003, SwitchMultilevel::Set - Setting to level 0
2017-04-01 15:41:20.398 Info, Node003, Duration: Default
2017-04-01 15:41:20.399 Detail, Node003, Setting Encryption Flag on Message For Command Class COMMAND_CLASS_SWITCH_MULTILEVEL
2017-04-01 15:41:20.399 Detail, Node003, Queuing (Send) SwitchMultilevelCmd_Set (Node=3): 0x01, 0x0b, 0x00, 0x13, 0x03, 0x04, 0x26, 0x01, 0x00, 0xff, 0x25, 0x4d, 0x50
2017-04-01 15:41:20.399 Detail, Node003, Setting Encryption Flag on Message For Command Class COMMAND_CLASS_SWITCH_MULTILEVEL
2017-04-01 15:41:20.399 Detail, Node003, Queuing (Send) SwitchMultilevelCmd_Get (Node=3): 0x01, 0x09, 0x00, 0x13, 0x03, 0x02, 0x26, 0x02, 0x25, 0x4e, 0xab
2017-04-01 15:41:20.402 Detail,
|
I noticed that |
ghost
added
Description:
This PR adds transition support to zwave lights. Unfortunately not all lights support it, since it was added with
COMMAND_CLASS_SWITCH_MULTILEVELversion 2. I've tested it with an Aeotec ZW098.