Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for static typing for the PECO library #68707

Merged
merged 15 commits into from Mar 29, 2022

Conversation

IceBotYT
Copy link
Contributor

@IceBotYT IceBotYT commented Mar 26, 2022

Proposed change

Adding support for static typing for the PECO library

Here's a diff between 0.0.21 and 0.0.25 IceBotYT/peco-outage-api@16f1ced..493e5c8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@IceBotYT IceBotYT marked this pull request as draft March 26, 2022 14:01
@IceBotYT IceBotYT marked this pull request as ready for review March 26, 2022 19:54
Copy link
Contributor

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gjohansson-ST
Copy link
Member

The PR description should include a changelog or diff between the versions in the upstream package

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the tests pass @IceBotYT

@IceBotYT
Copy link
Contributor Author

Please make sure the tests pass @IceBotYT

They're not related to my integration

@frenck
Copy link
Member

frenck commented Mar 27, 2022

They are...

image

Anyways, we cannot merge with failing tests; so it needs to be solved.

@IceBotYT
Copy link
Contributor Author

Oh oops. I will fix it when I get home.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Add support for static typing for the PECO library (follow up #65194) Add support for static typing for the PECO library Mar 27, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 28, 2022
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Mar 28, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @IceBotYT 👍

@frenck frenck merged commit fb14ae2 into home-assistant:dev Mar 29, 2022
@IceBotYT IceBotYT deleted the peco-library-typing branch March 29, 2022 14:36
IceBotYT added a commit to IceBotYT/core that referenced this pull request Mar 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants