New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for static typing for the PECO library #68707
Conversation
Merging to solve conflicts between this branch and upstream.
Doing another commit to re-trigger the CI
Solving extra merge conflicts
…into peco-library-typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The PR description should include a changelog or diff between the versions in the upstream package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the tests pass @IceBotYT
They're not related to my integration |
Oh oops. I will fix it when I get home. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @IceBotYT 👍
Proposed change
Adding support for static typing for the PECO library
Here's a diff between 0.0.21 and 0.0.25 IceBotYT/peco-outage-api@
16f1ced..493e5c8
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: