Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locally patch AirzoneLocalApi in tests #68770

Merged
merged 1 commit into from Mar 28, 2022

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Mar 28, 2022

Proposed change

Patch AirzoneLocalApi locally instead of globally.
This was requested by @bdraco in #68384 (comment).
However, previously accepted tests are missing this change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Patch AirzoneLocalApi locally instead of globally.

Signed-off-by: 脕lvaro Fern谩ndez Rojas <noltari@gmail.com>
@project-bot project-bot bot added this to Needs review in Dev Mar 28, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 28, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Noltari 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Mar 28, 2022
@frenck frenck merged commit 67d3e84 into home-assistant:dev Mar 28, 2022
Dev automation moved this from Reviewer approved to Done Mar 28, 2022
@Noltari Noltari deleted the airzone-tests-local-patches branch March 28, 2022 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants