Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion Blinds dhcp discovery #68809

Merged
merged 17 commits into from Mar 28, 2022
Merged

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Mar 28, 2022

Breaking change

Proposed change

Add DHCP discovery for the MotionBlinds integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 28, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 28, 2022
@starkillerOG starkillerOG changed the title Motion dhcp Motion Blinds dhcp discovery Mar 28, 2022
@starkillerOG
Copy link
Contributor Author

@bdraco could you review this PR since it is based on the comments you gave me in this merged PR: #68589

@starkillerOG
Copy link
Contributor Author

starkillerOG commented Mar 28, 2022

@bdraco does the mac need to be formatted to ab:cd:ef:gh:ij:kl in order for the DHCP discovery to correctly match using the {"registered_devices": true} ?

edit: currently the mac of the Motion Blinds integration is formatted as abcdefghijkl

@bdraco
Copy link
Member

bdraco commented Mar 28, 2022

Registered devices matches against the device registry, if you filled out connections, in device info, it will match

@starkillerOG
Copy link
Contributor Author

starkillerOG commented Mar 28, 2022

I did, although the mac is formatted as abcdefghijkl in the device registry connections.
So it will match then.

@bdraco
Copy link
Member

bdraco commented Mar 28, 2022

async_set_unique_id in the user path needs to set raise_on_progress=False so it doesn't abort if they choose the manual path over discovery

@starkillerOG
Copy link
Contributor Author

@bdraco I just added the raise_on_progress, thanks for the explanation, I did not know why I would have needed that :)

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Dev automation moved this from By Code Owner to Reviewer approved Mar 28, 2022
starkillerOG and others added 5 commits March 29, 2022 00:30
@starkillerOG
Copy link
Contributor Author

@bdraco any more feedback?

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@bdraco bdraco merged commit 98ca975 into home-assistant:dev Mar 28, 2022
Dev automation moved this from Reviewer approved to Done Mar 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants