New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion Blinds dhcp discovery #68809
Motion Blinds dhcp discovery #68809
Conversation
@bdraco does the mac need to be formatted to edit: currently the mac of the Motion Blinds integration is formatted as |
Registered devices matches against the device registry, if you filled out connections, in device info, it will match |
I did, although the mac is formatted as |
async_set_unique_id in the user path needs to set raise_on_progress=False so it doesn't abort if they choose the manual path over discovery |
@bdraco I just added the raise_on_progress, thanks for the explanation, I did not know why I would have needed that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco any more feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃憤
Breaking change
Proposed change
Add DHCP discovery for the MotionBlinds integration
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: