Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update throttle in LG Netcast #68902

Merged
merged 2 commits into from Mar 31, 2022

Conversation

Drafteed
Copy link
Contributor

Proposed change

Removing throttling from update method in LG Netcast integration, because it is not needed and makes it impossible to force data update through the homeassistant.update_entity service.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@balloob
Copy link
Member

balloob commented Mar 30, 2022

Why is it not needed?

@Drafteed
Copy link
Contributor Author

@balloob The LG Netcast API does not have any rate/requests limits. There is no need to change the order of updating data bypassing the standard update cycle.

@balloob balloob merged commit 2c49323 into home-assistant:dev Mar 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
@Drafteed Drafteed deleted the lgnetcast-remove-throttle branch July 28, 2022 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants