Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sensors for Airzone WebServer #69748

Merged
merged 7 commits into from May 14, 2022
Merged

Add Sensors for Airzone WebServer #69748

merged 7 commits into from May 14, 2022

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Apr 9, 2022 •
edited

Proposed change

Add Sensors for Airzone WebServer.

Airzone Zone(s) <-> Airzone System(s) <-> Airzone WebServer.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Apr 9, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 9, 2022
@Noltari Noltari mentioned this pull request Apr 22, 2022
Merged
22 tasks
@Noltari Noltari marked this pull request as draft April 22, 2022 12:11
@Noltari
Copy link
Contributor Author

Noltari commented Apr 22, 2022

Marking as draft until #70421 is merged

@Noltari
Copy link
Contributor Author

Noltari commented Apr 22, 2022

Rebased on top of #70421

@Noltari
Copy link
Contributor Author

Noltari commented Apr 23, 2022

#70421 has been merged in 6dc4486
I've now rebased this on latest upstream/dev and this PR is now ready for review :)

@Noltari Noltari marked this pull request as ready for review April 24, 2022 08:56
@Noltari Noltari marked this pull request as draft April 26, 2022 09:04
@Noltari Noltari marked this pull request as draft April 26, 2022 09:04
@Noltari
Copy link
Contributor Author

Noltari commented Apr 26, 2022

Needs rebase after latest Airzone changes.

@Noltari Noltari marked this pull request as ready for review April 26, 2022 09:32
@Noltari
Copy link
Contributor Author

Noltari commented Apr 26, 2022

Rebased on latest upstream/dev

@Noltari
airzone: add WebServer sensors
27f706f 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari force-pushed the airzone-webserver-sensors branch from 68f21a0 to 27f706f Compare May 9, 2022 14:41
@Noltari Noltari mentioned this pull request May 9, 2022
Merged
22 tasks
@Noltari
Copy link
Contributor Author

Noltari commented May 9, 2022

Rebased on latest upstream/dev after 88c2c5c #69736

@Noltari
airzone: sensor: disable webserver RSSI by default
c7a7d74 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
Copy link
Contributor Author

Noltari commented May 9, 2022

Failure in c7a7d74 is due to code coverage and not related to changes.

bdraco
bdraco requested changes May 9, 2022
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

Dev automation moved this from By Code Owner to Review in progress May 9, 2022
@Noltari Noltari requested a review from bdraco May 9, 2022 18:05
@Noltari
airzone: add changes suggested by @bdraco
df7ab7a 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
tests: airzone: remove leftover
271eb4d 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
Copy link
Contributor Author

Noltari commented May 10, 2022

Failure in 271eb4d is due to code coverage and not related to changes.

@Noltari
airzone: entity: refactor DeviceInfo declaration
d833a6d 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari requested a review from bdraco May 11, 2022 07:49
Dev automation moved this from Review in progress to Reviewer approved May 14, 2022
@bdraco bdraco merged commit e8a8d35 into home-assistant:dev May 14, 2022
Dev automation moved this from Reviewer approved to Done May 14, 2022
@Noltari Noltari deleted the airzone-webserver-sensors branch May 14, 2022 12:03
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: airzone new-feature
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Noltari @bdraco @homeassistant