Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute to zone indicating persons in zone #69767

Merged
merged 4 commits into from Apr 11, 2022
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 9, 2022

Proposed change

This PR adds a state attribute to the zone entity giving information about the state. The current state of a zone is the number of persons in that zone. This PR adds an entity_id attribute to the zone state that provides information on who those people are.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (zone) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck changed the title Ad attribute to zone indicating persons in zone Add attribute to zone indicating persons in zone Apr 9, 2022
@@ -456,6 +456,8 @@ class Platform(StrEnum):
# Temperature attribute
ATTR_TEMPERATURE: Final = "temperature"

# Persons attribute
ATTR_PERSONS: Final = "persons"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

persons or people?

For references to groups of a specific or general number, either people or persons may be used, but modern style guides tend to prefer people where earlier guides preferred persons, especially for countable groups.

https://www.merriam-webster.com/words-at-play/people-vs-persons

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It are person entities... ? So, besides grammar, I'm unsure. It is referring to entities, not actual human beings.

馃し I don't have a strong opinion, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think persons is better as we're referring to a specific set of individuals:
https://www.merriam-webster.com/words-at-play/people-vs-persons

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do persons.

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@balloob balloob merged commit 800bf92 into dev Apr 11, 2022
@balloob balloob deleted the frenck-2022-0849 branch April 11, 2022 06:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core has-tests integration: zone new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants