New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute to zone indicating persons in zone #69767
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
@@ -456,6 +456,8 @@ class Platform(StrEnum): | |||
# Temperature attribute | |||
ATTR_TEMPERATURE: Final = "temperature" | |||
|
|||
# Persons attribute | |||
ATTR_PERSONS: Final = "persons" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
persons or people?
For references to groups of a specific or general number, either people or persons may be used, but modern style guides tend to prefer people where earlier guides preferred persons, especially for countable groups.
https://www.merriam-webster.com/words-at-play/people-vs-persons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It are person
entities... ? So, besides grammar, I'm unsure. It is referring to entities, not actual human beings.
馃し I don't have a strong opinion, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think persons
is better as we're referring to a specific set of individuals:
https://www.merriam-webster.com/words-at-play/people-vs-persons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do persons.
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Proposed change
This PR adds a state attribute to the zone entity giving information about the state. The current state of a zone is the number of persons in that zone. This PR adds an
entity_id
attribute to the zone state that provides information on who those people are.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: