Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lyft sensor: re-enable Prime Time rate attribute #6982

Merged
merged 1 commit into from
Apr 22, 2017

Conversation

drkp
Copy link
Contributor

@drkp drkp commented Apr 8, 2017

Minor fix -- this was disabled originally because it appeared not to work without using the authenticated user api, but turns out this does work correctly even without a user login
(assuming that sandbox mode is disabled)

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Turns out this does work correctly even without a user login
(assuming that sandbox mode is disabled)
@brianjking
Copy link

@drkp - Wait, there's a Lyft sensor? Perhaps this is coming in 0.42! Either way, this is great! Thanks..

@drkp
Copy link
Contributor Author

drkp commented Apr 8, 2017

@brianjking - yes, see #6711 - in fact, the sensor is already in 0.41 although I think the documentation didn't make it in until 0.42

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 2c39038 into home-assistant:dev Apr 22, 2017
@balloob balloob mentioned this pull request May 5, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants