Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xknx to 0.20.2 #69853

Merged
merged 2 commits into from Apr 11, 2022
Merged

Update xknx to 0.20.2 #69853

merged 2 commits into from Apr 11, 2022

Conversation

marvin-w
Copy link
Contributor

Proposed change

Bump XKNX to 0.20.2 and properly handle shutdown of devices.

Be aware: This was not an issue before as during reloading we would completely reinitialize the whole module.

But maybe we want to support dynamic entity loading at some point then this would have been bad.

https://github.com/XKNX/xknx/releases/tag/0.20.2 (for the diff just click diff to 0.20.1)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Julius2342, @farmio, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 11, 2022
@frenck
Copy link
Member

frenck commented Apr 11, 2022

Should this go into a patch release?

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Apr 11, 2022
@marvin-w marvin-w added this to the 2022.4.3 milestone Apr 11, 2022
@marvin-w
Copy link
Contributor Author

Should this go into a patch release?

Yes, I tagged it

@marvin-w
Copy link
Contributor Author

marvin-w commented Apr 11, 2022

The test that got adjusted in this PR is from #69697 which is not part of 2022.4.*.

Do we need to tag this too since it's just tests or how do we proceed with that? If you just cherry-pick this it would most likely result in a failure.

@marvin-w marvin-w removed this from the 2022.4.3 milestone Apr 11, 2022
Dev automation moved this from By Code Owner to Review in progress Apr 11, 2022
Dev automation moved this from Review in progress to Reviewer approved Apr 11, 2022
@marvin-w marvin-w mentioned this pull request Apr 11, 2022
22 tasks
@farmio farmio merged commit 3d30a75 into dev Apr 11, 2022
Dev automation moved this from Reviewer approved to Done Apr 11, 2022
@farmio farmio deleted the feature/knx_shutdown_devices branch April 11, 2022 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed dependency has-tests integration: knx small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants