Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quickplay when casting splash for mediaplayer.turn_on #69866

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Apr 11, 2022

Proposed change

Use quickplay when casting splash for mediaplayer.turn_on to ensure:

  • We wait until the request to display the image is sent before returning
  • The Homeassistant Mediaplayer app is used to cast the media, instead some other running app which is supporting the media namespace but may not allow casting a png image.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Apr 11, 2022
@emontnemery emontnemery added this to the 2022.4.3 milestone Apr 11, 2022
Dev automation moved this from Needs review to Reviewer approved Apr 12, 2022
@balloob balloob merged commit 1645ab2 into dev Apr 12, 2022
Dev automation moved this from Reviewer approved to Done Apr 12, 2022
@balloob balloob deleted the cast_on_wait branch April 12, 2022 17:06
@balloob balloob mentioned this pull request Apr 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Cast integration failing after 2022.4.0 update
3 participants