Hide credentials from generated titles in generic camera #70204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
has-tests
integration: generic
small-pr
davet2001
changed the title
bdraco
reviewed
Apr 17, 2022
| def slug_url(url) -> str | None: | ||
| """Convert a camera url into a string suitable for a camera name.""" | ||
| if not url: | ||
| return None | ||
| url = URL_RE.sub("//", url) | ||
| url_no_scheme = urlparse(url)._replace(scheme="") |
There was a problem hiding this comment.
Untested, but I think it makes sense to do something like _replace(username=None)._replace(password=None) instead?
https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlparse
There was a problem hiding this comment.
Let's use yarl instead of urlparse. We use that in most other places in Home Assistant that do URL manipulation too.
balloob
approved these changes
Apr 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When the generic camera integration is set up via a config flow, a title is automatically generated based on the url.
Unfortunately the generated string also includes credentials
e.g.
rtsp://username:pass@192.168.0.10/xxxcreates title
username_pass_192_168_0_10_xxxThis PR drops the credentials from the URL before generating the title string.
Update:
To deal with other places there could be sensitive parameters, the PR now just uses the hostname.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: