Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix Airzone config flow #70474

Merged
merged 2 commits into from Apr 26, 2022

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Apr 23, 2022

Proposed change

Improve and fix Airzone config flow:

  • A user can add multiple config entries for the same Airzone device for those Airzone devices that support all systems listing (systemID=0) since _async_abort_entries_match is being checked with CONF_ID always set, but if the Airzone device supports systemID=0, CONF_ID won't be set. This bug was introduced in Support specifying Airzone System ID聽#69751 c76b21e.
  • Extend SYSTEM_ID_SCHEMA from CONFIG_SCHEMA.
  • invalid_system_id error refers to CONF_ID.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- A user can add multiple config entries for the same Airzone device for those
Airzone devices that support all systems listing (systemID=0) since
_async_abort_entries_match is being checked with CONF_ID always set, but if
the Airzone device supports systemID=0, CONF_ID won't be set.
- Extend SYSTEM_ID_SCHEMA from CONFIG_SCHEMA.
- invalid_system_id error refers to CONF_ID.

Signed-off-by: 脕lvaro Fern谩ndez Rojas <noltari@gmail.com>
@project-bot project-bot bot added this to Needs review in Dev Apr 23, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 23, 2022
@gjohansson-ST
Copy link
Member

Any particular reason not to display the system id already first time?

@Noltari
Copy link
Contributor Author

Noltari commented Apr 23, 2022

Any particular reason not to display the system id already first time?

Yes, newer devices support setting the system id to 0, which automatically lists all connected systems. Older devices do not support this and the system id has to be specified.
I鈥檓 not sure if those older systems support more than one system connected or not.
However, @frenck suggested doing it this way on the referenced PR: #69751 (comment)
And I also think it鈥檚 better to do it that way, since most users won鈥檛 know what to enter in the config or ir 0 is even a possibility since system id should be 1-32.

Signed-off-by: 脕lvaro Fern谩ndez Rojas <noltari@gmail.com>
@Noltari Noltari requested a review from bdraco April 25, 2022 12:45
Dev automation moved this from By Code Owner to Reviewer approved Apr 26, 2022
@bdraco bdraco merged commit 8d71595 into home-assistant:dev Apr 26, 2022
Dev automation moved this from Reviewer approved to Done Apr 26, 2022
@Noltari Noltari deleted the airzone-config-flow-improvements branch April 26, 2022 05:06
@Noltari
Copy link
Contributor Author

Noltari commented Apr 26, 2022

Thanks @bdraco! 馃帀

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants