New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pysensibo to 1.0.12 #70484
Bump pysensibo to 1.0.12 #70484
Conversation
Hey there @andrey-git, mind taking a look at this pull request as it has been labeled with an integration ( |
The failure was unrelated , I restarted that job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing a trace with this change
2022-04-23 09:31:45 ERROR (MainThread) [homeassistant.components.sensibo] Unexpected error fetching sensibo data: 'NoneType' object has no attribute 'get'
Traceback (most recent call last):
File "/Users/bdraco/home-assistant/homeassistant/helpers/update_coordinator.py", line 191, in _async_refresh
self.data = await self._async_update_data()
File "/Users/bdraco/home-assistant/homeassistant/components/sensibo/coordinator.py", line 43, in _async_update_data
data = await self.client.async_get_devices_data()
File "/Users/bdraco/home-assistant/venv/lib/python3.9/site-packages/pysensibo/__init__.py", line 181, in async_get_devices_data
"last_reset": filters.get("lastFiltersCleanTime", {}).get("time")
AttributeError: 'NoneType' object has no attribute 'get'
Was working fine for me before and still works fine but I reverted my thinking a bit on this so I feel more sure it should sort all scenarios now. Great if you give it a go with your config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine with the latest version
Proposed change
Bump pysensibo to 1.0.12 for sensibo integration
andrey-git/pysensibo@1.0.10...1.0.12
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: