Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pysensibo to 1.0.12 #70484

Merged
merged 2 commits into from Apr 23, 2022
Merged

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Apr 23, 2022

Proposed change

Bump pysensibo to 1.0.12 for sensibo integration
andrey-git/pysensibo@1.0.10...1.0.12

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @andrey-git, mind taking a look at this pull request as it has been labeled with an integration (sensibo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 23, 2022
@bdraco
Copy link
Member

bdraco commented Apr 23, 2022

The failure was unrelated , I restarted that job

Dev automation moved this from By Code Owner to Reviewer approved Apr 23, 2022
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a trace with this change

2022-04-23 09:31:45 ERROR (MainThread) [homeassistant.components.sensibo] Unexpected error fetching sensibo data: 'NoneType' object has no attribute 'get'
Traceback (most recent call last):
  File "/Users/bdraco/home-assistant/homeassistant/helpers/update_coordinator.py", line 191, in _async_refresh
    self.data = await self._async_update_data()
  File "/Users/bdraco/home-assistant/homeassistant/components/sensibo/coordinator.py", line 43, in _async_update_data
    data = await self.client.async_get_devices_data()
  File "/Users/bdraco/home-assistant/venv/lib/python3.9/site-packages/pysensibo/__init__.py", line 181, in async_get_devices_data
    "last_reset": filters.get("lastFiltersCleanTime", {}).get("time")
AttributeError: 'NoneType' object has no attribute 'get'

Dev automation moved this from Reviewer approved to Review in progress Apr 23, 2022
@gjohansson-ST gjohansson-ST changed the title Bump pysensibo to 1.0.11 Bump pysensibo to 1.0.12 Apr 23, 2022
@gjohansson-ST
Copy link
Member Author

Was working fine for me before and still works fine but I reverted my thinking a bit on this so I feel more sure it should sort all scenarios now. Great if you give it a go with your config.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine with the latest version

Dev automation moved this from Review in progress to Reviewer approved Apr 23, 2022
@bdraco bdraco merged commit 859dcb3 into home-assistant:dev Apr 23, 2022
Dev automation moved this from Reviewer approved to Done Apr 23, 2022
@gjohansson-ST gjohansson-ST deleted the pysensibo_1011 branch April 24, 2022 08:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants